-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nextflow-vep: separate out CLI params configuration #1497
Merged
nuno-agostinho
merged 8 commits into
Ensembl:postreleasefix/112
from
nakib103:config_channel_separation
Jan 5, 2024
Merged
nextflow-vep: separate out CLI params configuration #1497
nuno-agostinho
merged 8 commits into
Ensembl:postreleasefix/112
from
nakib103:config_channel_separation
Jan 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Has this been tested? |
nuno-agostinho
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @nakib103, this PR seems to be working as intended!
All scenarios work when using the main workflow and also the sub-workflow works as expected. Thanks!
Merged to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nextflow-vep does not allow many-to-many scenario between input VCF and VEP config files. This PR allows for the case where we use nextflow-vep from another pipeline. This is achieved by separating out the processing of CLI params and allocating that jobs to main workflow (which is used when we call nextflow-vep from CLI).
It is the responsibility of the workflow that is calling nextflow-vep to pass the VCF file and related VEP config inside a tuple.
meta map: we also introduce meta map as input parameter to vep workflow -
It is useful to use it instead of long length of parameters list in the process input. Some of which are only passed through to be used by some other downstream process.
Test
You can create a test nextflow pipeline to test the new updates -
nextflow-vep should also be tested in CLI mode to see if one-to-one, one-to-many, and many-to-one scenario works.