refactor :: 비즈니스 예외 분리

EntryDSM · Apr 10, 2024 · b624650 · b624650
1 parent 218a922
commit b624650
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 5 deletions.
diff --git a/src/main/kotlin/hs/kr/equus/user/domain/auth/service/SendCertificationNumberService.kt b/src/main/kotlin/hs/kr/equus/user/domain/auth/service/SendCertificationNumberService.kt
@@ -9,8 +9,10 @@ import hs.kr.equus.user.global.utils.sms.SMSUtil
 import net.nurigo.sdk.message.model.Message
 import net.nurigo.sdk.message.request.SingleMessageSendingRequest
 import net.nurigo.sdk.message.service.DefaultMessageService
+import org.apache.http.client.HttpResponseException
 import org.springframework.stereotype.Service
 import org.springframework.transaction.annotation.Transactional
+import java.io.IOException
 
 @Transactional
 @Service
@@ -19,7 +21,15 @@ class SendCertificationNumberService(
     private val certificationInfoRepository: CertificationInfoRepository
 ) {
     fun execute(phoneNumber: String) {
-        val certificationNumber = smsUtil.sendCertificationMessage(phoneNumber)
+        val certificationNumber: Int
+
+        try {
+            certificationNumber = smsUtil.sendCertificationMessage(phoneNumber)
+        } catch (e: IOException) {
+            throw InvalidSMSConnectException
+        } catch (e: HttpResponseException) {
+            throw SMSBadRequestException
+        }
 
         certificationInfoRepository.save(
             CertificationInfo(

diff --git a/src/main/kotlin/hs/kr/equus/user/global/utils/sms/SMSUtil.kt b/src/main/kotlin/hs/kr/equus/user/global/utils/sms/SMSUtil.kt
@@ -1,13 +1,13 @@
 package hs.kr.equus.user.global.utils.sms
 
-import hs.kr.equus.user.domain.auth.exception.InvalidSMSConnectException
 import hs.kr.equus.user.domain.auth.exception.SMSBadRequestException
 import hs.kr.equus.user.global.property.SmsProperties
 import net.nurigo.sdk.message.model.Message
 import net.nurigo.sdk.message.request.SingleMessageSendingRequest
 import net.nurigo.sdk.message.service.DefaultMessageService
-import net.nurigo.sdk.message.service.MessageService
+import org.apache.http.client.HttpResponseException
 import org.springframework.stereotype.Component
+import java.io.IOException
 import kotlin.random.Random
 
 @Component
@@ -25,10 +25,10 @@ class SMSUtil(
         )
 
         val response = messageService.sendOne(SingleMessageSendingRequest(message))
-            ?: throw InvalidSMSConnectException
+            ?: throw IOException("SMS 서비스 연결 실패")
 
         if (response.statusCode.toInt() in 400..500) {
-            throw SMSBadRequestException
+            throw HttpResponseException(response.statusCode.toInt(), "잘못된 요청 또는 서버 오류")
         }
 
         return certificationNumber