Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More accurate centered play section #22

Open
FANMixco opened this issue May 16, 2021 · 0 comments
Open

More accurate centered play section #22

FANMixco opened this issue May 16, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@FANMixco
Copy link
Owner

With the new long screen devices, the play section is not very centered friendly. Right now, the play section has a workaround with a CSS class called .longPhonePortrait it's called in the last section of timer.js.

The main logic behind this trick is: "it calculates if the width is less than the double of the height." If it's then it applies the .longPhonePortrait.

Another option would be to provide the precise height to innerPlayContainer that subtract the footer and upper components height. If this is done, then you could try centering this div in the right location.

For now, the current workaround is good enough.

@FANMixco FANMixco added enhancement New feature or request help wanted Extra attention is needed labels May 16, 2021
@FANMixco FANMixco added this to the Summer 2022 milestone May 17, 2021
@FANMixco FANMixco added the good first issue Good for newcomers label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant