Notifications fired allways even if not watchedAttribute changes

[javicond3]

Notifications sent even if the watchedAttribute does not change. I reproduce the issue with the following example:

1. Create the entity:

curl -iX POST 'http://localhost:1026/ngsi-ld/v1/entityOperations/create' \
-H 'Content-Type: application/ld+json' \
--data-raw '[
{
   "id":"urn:ngsi-ld:AirQualityObserved:Guadalajara:ES1537A",
   "type":"AirQualityObserved",
   "pm10":{
      "type":"Property",
      "value": 1
   },
   "so2":{
      "type":"Property",
      "value": 2
   },
   "@context": ["https://smartdatamodels.org/context.jsonld"]
}
]'

2. Create the subscription (it should fire when the pm10 attribute changes):

curl -L -X POST 'http://localhost:1026/ngsi-ld/v1/subscriptions/' \
-H 'Content-Type: application/ld+json' \
--data-raw '{
  "description": "A subscription to get air quality",
  "type": "Subscription",
  "entities": [{
    "type": "AirQualityObserved"
    }],
  "watchedAttributes": [
      "pm10"
    ],
  "notification": {
    "endpoint": {
      "uri": "http://localhost:3000/ld/notify",
      "accept": "application/json"
    }
  },
    "@context": "https://smartdatamodels.org/context.jsonld"
}'

3. Update the entity (the so2 attribute so the notification should not be fired):

curl -iX PATCH 'http://localhost:1026/ngsi-ld/v1/entities/urn:ngsi-ld:AirQualityObserved:Guadalajara:ES1537A/attrs' \
-H 'Content-Type: application/ld+json' \
--data-raw '{
   "so2":{
      "type":"Property",
      "value": 40
   },
   "@context": ["https://smartdatamodels.org/context.jsonld"]
}'

4. Result: I receive the notification ❌
5. Expected: The notification should not be sent

[kzangeli]

That's exactly what you should expect.
If you think of it a little, the value might not have been modified, but the "modifiedAt" has - meaning the value is new, not "old" anymore and this is important info for the temporal database.

That said, it's not interesting for everybody and if you start Orion-LD with the CLI -noNotifyFalseUpdate then the notification will not be sent.
This will be a field in the subscription and not a global flag for the broker ... some day. We've already discussed this in ETSI ISG CIM where we define the NGSI-LD API.

So, try that CLI and close the issue if it is working as you propose/expect.

Thanks for reporting, even though this time it seems to be a "false positive" :)

[kzangeli]

Hi again.
A colleague of mine stumbled upon this issue the other day and it seems like I misread the issue.
I answered on a non-related topic.
Sorry about that. Seems like I concentrated on the update and not o the "watchedAttributes" of the subscription.
So, I'll look into this. If what you are reporting is true, it's an important bug that I need to fix asap.

Just one doubt.
What are the CLI parameters you use when starting the broker?

[kzangeli]

So, I've seen the bug and I've seen that you are not using the -experimental CLI param (or its corresponding env var ORIONLD_EXPERIMENTAL).
It works as it should when -experimental is used, so, while the bug should be fixed, it's old code, using the old deprecated driver for mongo.
The new implementation (turned on with the -experimental CLI param) uses the newest driver for mongoc and once the broker has been enough tested, the "experimental" mode will be set as default.

So, I'd propose you start using -experimental mode and see how it goes. It's a step in the right direction

[javicond3]

Thanks,

I will try it with the experimental mode.

[kzangeli]

It's not as "experimental as it sounds.I have ~500 functersts that make sure it's all working.
It was "experimental" in the very beginning, when I named the cli option

[pierre-josselin]

I encounter exactly the same problem (Orion-LD 1.1.2). I have a single subscription with the watched attribute temperature, but when only humidity attribute is changed, the notification is still sent. I enabled ORIONLD_EXPERIMENTAL=TRUE which did not fix the problem.

[kzangeli]

I enabled ORIONLD_EXPERIMENTAL=TRUE which did not fix the problem.

ok, that's interesting.
However, @javicond3 closed the issue, I assume he did that because he was happy with it.
Orion-LD 1.1.2 is rather old.
Please try with a newer version of the broker and if you still see the error, then
post the complete info I need to be able to reproduce.

This should be enough:

• Complete CLI params for the broker,
• the payload body of the creation of the subscription,
• the URL+body of the update that provokes the non-wanted notification