-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue #1412 re-connecting to postgres when connection is lost #1416
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ |
refering to issue #1412 |
poolP->connectionV[ix] = NULL; | ||
LM_W(("Connection failed, pointer of item %d was re-set to NULL (%p)", ix, poolP->connectionV[ix])); | ||
// this time no success finding a connection that is working, try in the next loop | ||
continue; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You seem to have changed the indentation to 4 spaces.
I'd really prefer to have two spaces, as in the rest of the code base.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the indentation to 2 spaces.
Thank you for contributing!
|
I have read the CLA Document and I hereby sign the CLA |
Thank You very much for contributing! |
Proposed changes
It fixes that the PostgreSQL connections where not re-connected once they are closed by the PostgreSQL server (e.q. restart of the server or network problems)
Types of changes
What types of changes does your code introduce to the project: Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any ofthem, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...