Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #1412 re-connecting to postgres when connection is lost #1416

Merged
merged 4 commits into from
Aug 25, 2023

Conversation

cfreyfh
Copy link

@cfreyfh cfreyfh commented Aug 25, 2023

Proposed changes

It fixes that the PostgreSQL connections where not re-connected once they are closed by the PostgreSQL server (e.q. restart of the server or network problems)

Types of changes

What types of changes does your code introduce to the project: Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...

@github-actions
Copy link

github-actions bot commented Aug 25, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️

@cfreyfh
Copy link
Author

cfreyfh commented Aug 25, 2023

refering to issue #1412

poolP->connectionV[ix] = NULL;
LM_W(("Connection failed, pointer of item %d was re-set to NULL (%p)", ix, poolP->connectionV[ix]));
// this time no success finding a connection that is working, try in the next loop
continue;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You seem to have changed the indentation to 4 spaces.
I'd really prefer to have two spaces, as in the rest of the code base.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the indentation to 2 spaces.

@kzangeli
Copy link
Collaborator

Thank you for contributing!
github asks you to "sign the Contributor License Agreement", by just addding a comment with the text:

I have read the CLA Document and I hereby sign the CLA

@cfreyfh
Copy link
Author

cfreyfh commented Aug 25, 2023

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Aug 25, 2023
@kzangeli kzangeli merged commit 513edcd into FIWARE:develop Aug 25, 2023
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2023
@kzangeli
Copy link
Collaborator

Thank You very much for contributing!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants