Skip to content
This repository has been archived by the owner on May 20, 2024. It is now read-only.

Score cone command stops on button release #204

Open
dkt01 opened this issue Mar 27, 2023 · 2 comments
Open

Score cone command stops on button release #204

dkt01 opened this issue Mar 27, 2023 · 2 comments
Assignees
@Litemage
Labels
autonomous bug Something isn't working lifter

Comments

@dkt01
Copy link
Member

dkt01 commented Mar 27, 2023

To place a cone, driver must hold the right trigger. Expected behavior is that place should complete on single press, not press and hold.

Low priority since this has apparently been present through at least one competition
@dkt01 dkt01 added bug Something isn't working autonomous lifter labels Mar 27, 2023
@dkt01 dkt01 added this to the CMP milestone Mar 27, 2023
@Litemage Litemage self-assigned this Apr 1, 2023
@Litemage
Copy link
Contributor

Litemage commented Apr 1, 2023

Pretty sure that this is caused by the score cone trigger's .OnTrue and OnFalse respective commands fighting over control of the intake subsystem. Changed the ScoreConeCommand to cancel incoming in this case in 27231d5

@Litemage
Copy link
Contributor

Litemage commented Apr 8, 2023

Making the score cone command not cancellable could put the robot in a state where the ScoreConeCommand never ends, which can be a bit scary. Backlogging for now.

@dkt01 dkt01 removed this from the CMP milestone Apr 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Litemage Litemage

Labels
autonomous bug Something isn't working lifter
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

204-score-cone-command-stops-on-button-release FRC1756-Argos/2023-Robot
2 participants
@dkt01 @Litemage