Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poor Performance Due to Configuration Loading #15

Open
Rich-Lang opened this issue Sep 13, 2018 · 1 comment
Open

Poor Performance Due to Configuration Loading #15

Rich-Lang opened this issue Sep 13, 2018 · 1 comment

Comments

@Rich-Lang
Copy link

This module needs a major overhaul to the configuration loading procedure. The module loads from the configuration system every time a request comes in which is a very expensive operation. Module should be updated to take advantage of ModuleContexts to act as a cache for configuration settings. See the following blogpost for discussion of this: http://www.ksingla.net/2008/12/using-imetadatainfogetmodulecontextcontainer-to-store-configuration-data/

To give an idea of the performance impact the attached file shows two very simple load tests which runs against the File->New Sample of an ASP.NET MVC application. The load test has 50 users hitting the pages for 2 minutes. The module isn't even enabled, so its purely the check for the enabled flag which is consuming the time. In the image, the 1st circle represents with the module, the 2nd circle represents removing the module from the section of the site.

run7and8

@alexhass
Copy link

alexhass commented Nov 5, 2018

Any progress on this serious issue? We need to save CPU cycles, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants