Addons path on Release builds?

[danbrakeley]

Hi, where should I put an Addon so that it can be seen by a Release build of EarTrumpet? I'm looking at HardwareSupportAddon right now, which tries putting the addon in <release-exe-path>\Addons\EarTrumpet.HardwareControls\, but then that just outputs a UI AddonResolver SelectAddon error that the Version string portion was too short or too long. From the code, it is looking for a version string in the path, but in what format, and for what purpose?

[danbrakeley]

So far I've tried <exe>\Addons\2.2.1.0\, <exe>\Addons\2.2.1\ and <exe>\Addons\2.2\, and I'm getting errors like the following:

...
16:20:14.303 UI AddonResolver Load
16:20:14.304 UI AddonResolver SelectAddon: D:\dev\eartrumpet\EarTrumpet\Build\Release\Addons\2.2
16:20:14.307 UI AddonResolver SelectAddon: System.FormatException: Input string was not in a correct format.
   at System.Version.VersionResult.SetFailure(ParseFailureKind failure, String argument)
   at System.Version.TryParseComponent(String component, String componentName, VersionResult& result, Int32& parsedComponent)
   at System.Version.TryParseVersion(String version, VersionResult& result)
   at System.Version.Parse(String input)
   at EarTrumpet.Extensibility.Hosting.AddonResolver.<>c.<SelectAddon>b__3_1(String f) in D:\dev\eartrumpet\EarTrumpet\EarTrumpet\Extensibility\Hosting\AddonResolver.cs:line 58
   at System.Linq.Enumerable.<>c__DisplayClass7_0`3.<CombineSelectors>b__0(TSource x)
   at System.Linq.Enumerable.WhereSelectArrayIterator`2.MoveNext()
   at System.Linq.Buffer`1..ctor(IEnumerable`1 source)
   at System.Linq.OrderedEnumerable`1.<GetEnumerator>d__1.MoveNext()
   at System.Linq.Buffer`1..ctor(IEnumerable`1 source)
   at System.Linq.Enumerable.<ReverseIterator>d__75`1.MoveNext()
   at EarTrumpet.Extensibility.Hosting.AddonResolver.SelectAddon(String path) in D:\dev\eartrumpet\EarTrumpet\EarTrumpet\Extensibility\Hosting\AddonResolver.cs:line 59
16:20:14.308 UI AddonResolver SelectAddon: Return without selection: D:\dev\eartrumpet\EarTrumpet\Build\Release\Addons\2.2
...

[riverar]

Hey @danbrakeley, the logic you're looking for is in AddonResolver.cs!SelectAddon:
https://github.com/File-New-Project/EarTrumpet/blob/master/EarTrumpet/Extensibility/Hosting/AddonResolver.cs#L57-L67

e.g. EarTrumpet\Addons\MyAddon\0.0.0.0\MyAddon.dll

This addon version number is used to compare against the EarTrumpet version; we won't load external addons that are built for a newer EarTrumpet.

[danbrakeley]

Thanks, that did it!

[riverar]

@danbrakeley EarTrumpet development slowed down / paused right around the time we were readying to ship add-on support. The plan was to let folks drop files into %LocalAppData%\EarTrumpet\Addons. We have a whole repository of docs/samples I can invite you to if you're interested in taking a look. (I haven't recently verified the addons work with or compile with master, but I can fix that up.)

[danbrakeley]

I'd love that, yeah! I'm having fun getting the HardwareSupport addon to work the way I want, and I plan on continuing to poke at it at least in the near future. I think the original author(s) also dropped off at some point, but I've got a fork I'm actively working on here: github.com/danbrakeley/EarTrumpet.HardwareSupportAddon.