Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Add known install/executable locations to external-player-map.json #5215

Open
3 tasks done
absidue opened this issue Jun 2, 2024 · 0 comments
Open
3 tasks done

Comments

@absidue
Copy link
Member

absidue commented Jun 2, 2024

Guidelines

  • I have searched the issue tracker for open and closed issues that are similar to the feature request I want to file, without success.
  • I have searched the documentation for information that matches the description of the feature request I want to file, without success.
  • This issue contains only one feature request.

Problem Description

By default FreeTube is only able to launch an external player if it finds it in the user's PATH, if it doesn't find it the user is confronted with a rather confusing error message. To get around that error message the user has to manually specify the path to the external player executable in the FreeTube settings, which especially for non-technical users that might not know where their programs are installed, is not a particularly user friendly process.

Proposed Solution

To provide a better out-of-the-box experience known executable locations for each operating system could be added to the external-player-map.json file. That would mean that users that have their external player installed to a standard location, would no longer have to manually enter the path to the player executable. Users that use non-standard locations or portable versions of the external player would still have to specify the location manually, however those users are more likely to be technical and aware of where their player executable is located.

The proposed flow would be:

  1. If the user has specified a custom command or path, use that.
  2. Try launching the player from the PATH.
  3. Try launching with the known install locations
  4. If all of the above fails, then fallback to showing an error message to the user.

Alternatives Considered

Providing a better error message so that the user knows how to fix the issue.

Issue Labels

ease of use improvement, improvement to existing feature, support for external software

Additional Information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

1 participant