Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure all tools wait for keypress on exit when in DOS 2.x #20

Open
tschak909 opened this issue Mar 25, 2021 · 1 comment
Open

Make sure all tools wait for keypress on exit when in DOS 2.x #20

tschak909 opened this issue Mar 25, 2021 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@tschak909
Copy link
Contributor

Care needs to be taken to make sure, especially for the query tools (FLD, FLH, FCONFIG), that a message similar to

PRESS [RETURN] TO CONTINUE

Is displayed if not running in a CLI dos. You can see examples of this in various tools, e.g.:
https://github.com/FujiNetWIFI/fujinet-config-tools/blob/master/flh/src/main.c#L90

Care should be taken to display this when an SIO query fails, so that the error message can be seen.
@tschak909 tschak909 added enhancement New feature or request good first issue Good for newcomers labels Mar 25, 2021
@eyvind eyvind mentioned this issue Mar 28, 2021
Merged
@jellonek
Copy link
Contributor

jellonek commented May 6, 2021

The fix for that was already merged in #21 so IMO this one should be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jellonek @tschak909