Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make table rendering consistent across commands #29

Open
herver opened this issue Feb 24, 2023 · 5 comments
Open

Make table rendering consistent across commands #29

herver opened this issue Feb 24, 2023 · 5 comments

Comments

@herver
Copy link
Collaborator

herver commented Feb 24, 2023

With the updated prettytable-rs from #28 I played a little bit to get a more consistent table output, mainly for enclosure and disks listing.

h3. Current output

  • Enclosure listing
    image

  • Disks listing
    image

h4. Possible new output format

  • Enclosure listing
    image

  • Disks listing
    image

What is your feeling on this ?

@herver herver changed the title Unifi table rendering Make table rendering consistent across commands Feb 24, 2023
@araujobsd
Copy link
Collaborator

I feel it is beautiful :)
It looks way better, thanks to work on this.

Can we have a PR with these changes?

@araujobsd
Copy link
Collaborator

araujobsd commented Feb 25, 2023

And plus you managed to sort the SLOT, which is a big plus :)

But need to be sure the sort in the slots really match the DISK and MAP, that was very hard for me to make, and I gave up in the end.

Comparing the images before/after, looks like the Array slot isn't right anymore with the "sort", would be interesting if you could double check it.

@araujobsd
Copy link
Collaborator

Example to check:
Before sort:
dev: dev/sg20 map: /dev/sdu slot: 18
After sort:
dev: dev/sg20 map: /dev/sdu slot: 20

@herver
Copy link
Collaborator Author

herver commented Feb 25, 2023

And plus you managed to sort the SLOT, which is a big plus :)

But need to be sure the sort in the slots really match the DISK and MAP, that was very hard for me to make, and I gave up in the end.

Comparing the images before/after, looks like the Array slot isn't right anymore with the "sort", would be interesting if you could double check it.

I haven't explicitly sorted anything...
For the array -> slot mapping, the screenshot comes from a different model of JBOD, that didn't enumerate in the same order, but I will make sure it doesn't change :)

@araujobsd
Copy link
Collaborator

@herver feel free to open an MR with these changes, it really looks better than what is presented right now. I personally liked a lot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants