-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make table rendering consistent across commands #29
Comments
I feel it is beautiful :) Can we have a PR with these changes? |
And plus you managed to sort the SLOT, which is a big plus :) But need to be sure the sort in the slots really match the DISK and MAP, that was very hard for me to make, and I gave up in the end. Comparing the images before/after, looks like the Array slot isn't right anymore with the "sort", would be interesting if you could double check it. |
Example to check: |
I haven't explicitly sorted anything... |
@herver feel free to open an MR with these changes, it really looks better than what is presented right now. I personally liked a lot :) |
With the updated
prettytable-rs
from #28 I played a little bit to get a more consistent table output, mainly for enclosure and disks listing.h3. Current output
Enclosure listing
![image](https://user-images.githubusercontent.com/218323/221102347-3b65a21e-f6dc-460a-8cf6-6ca4fe6de942.png)
Disks listing
![image](https://user-images.githubusercontent.com/218323/221102692-5143ddce-c942-43be-aba1-e193d64b625f.png)
h4. Possible new output format
Enclosure listing
![image](https://user-images.githubusercontent.com/218323/221103226-e1ca3a4c-4629-4f99-a1e7-38960a2de96d.png)
Disks listing
![image](https://user-images.githubusercontent.com/218323/221103196-973600ec-687d-4877-804b-a76c9e9b874c.png)
What is your feeling on this ?
The text was updated successfully, but these errors were encountered: