Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomFont for ThumbnailIcon doesn't reflects to TreeIcon #16

Open
jonascarlbaum opened this issue Feb 1, 2021 · 0 comments
Open

CustomFont for ThumbnailIcon doesn't reflects to TreeIcon #16

jonascarlbaum opened this issue Feb 1, 2021 · 0 comments

Comments

@jonascarlbaum
Copy link

jonascarlbaum commented Feb 1, 2021

Using CustomFont on ThumbnailIcon and adding <add key="FontThumbnail.EnableTreeIcons" value="true"/> in web.config doesn't generate any tree icon.

I have the FontAwesome PRO-set and are using it like this:
[ThumbnailIcon("fa-light-300.ttf", 0xf022)] for the list-alt icon in FAL.

Configured like this:

    <add key="FontThumbnail.BackgroundColor" value="#0b496e" />
    <add key="FontThumbnail.ForegroundColor" value="#ffffff" />
    <add key="FontThumbnail.FontSize" value="40" />
    <add key="FontThumbnail.CustomFontPath" value="Assets\vendors\" />
    <add key="FontThumbnail.EnableTreeIcons" value="true"/>

Of course I can use two attributes to get it to work with the wrong font.

    [ThumbnailIcon("fa-light-300.ttf", 0xf022)]
    [TreeIcon(FontAwesome5Regular.ListAlt)]

But it would be nice if it was possible to do something like adding a third parameter for Page Tree Icon-fallback:

[ThumbnailIcon("fa-light-300.ttf", 0xf022, "fal fa-list-alt")]

Or supporting adding class as free text in TreeIcon

[TreeIcon("fal fa-list-alt")]

The free text "thingy" would make completely different icon fonts (not only adding support of FontAwesome PRO) usable in page tree too, as you already solved for thumbnail icons in ThumbnailIcon-attribute by having ttf-reference and charcode-support... 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant