Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace use of netcat in the test suite with something less fragile. #216

Open
kwannoel opened this issue Sep 22, 2021 · 1 comment
Open

Comments

@kwannoel
Copy link
Contributor

In GitLab by @isd on Sep 7, 2021, 03:53

We've had problems with the use of nc in the integration tests, for a couple reasons:

  • The try/finally macros we're using don't seem to run on SIGTERM, so that can leave processes running after glow has been killed.
  • There are different versions of netcat with incompatible flags on different systems.

We should replace this with something more robust, perhaps in-process network support. I don't really anticipate in the long term that invoking glow with --handhsake will be common.

@kwannoel
Copy link
Contributor Author

In GitLab by @isd on Sep 7, 2021, 03:54

mentioned in merge request !168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant