Output of which
command in Phoenix is wrong for built-in apps (eg, Terminal and Phoenix)
#500
Open
1 of 4 tasks
Issue Description
Several apps are included as part of the Puter distribution. These have their URL set in the DB with a prefix of
https://builtins.namespaces.puter.com/
, which is automatically replaced with whatever the real domain is. However, this original fake domain shows up inwhich
output. The purpose ofwhich
is to tell you the real location of an executable, so we want the true URL displayed here.This is quite minor, but we probably want all users of the API to get the actual app urls, not fake ones.
Steps to Reproduce
which terminal
Expected & Actual Behavior
Note that the result is
https://builtins.namespaces.puter.com/terminal
which is the fake url, whereas the real one (for me) ishttp://puter.localhost:4100/builtin/terminal
.Addition Information or Screenshots (if applicable)
I attempted to apply the conversion from here:
puter/src/helpers/launch_app.js
Line 158 in 04adade
...to here:
puter/packages/backend/src/om/entitystorage/AppES.js
Line 163 in dc5b010
...but there are a couple of issues. One, I wasn't able to remove the original conversion from
launch_app()
because that's apparently using a different API endpoint that's unrelated to that AppES one. And two, modifying the output from the DB like this feels wrong, in that we might want to display the true DB value in an app management GUI.So, the best option might be to duplicate that conversion in
which
itself. I'd like to avoid that though.Deployment
npm run start
)docker run
)docker-compose
)Puter version (if accessible)
The text was updated successfully, but these errors were encountered: