Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: do we need a better way of identifying "childhood diseases"? #213

Open
celiot-IDM opened this issue Nov 3, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@celiot-IDM
Copy link
Collaborator

celiot-IDM commented Nov 3, 2022

There's a feature whereby a scenario can be identified as having steadily decreasing levels of childhood disease:

image

Currently tasks affected by decreasing childhood disease are defined to be those where RelevantPop == "1-4". Tasks with this population label happen less over time as the affected portion of the group population decreases.

This definition is problematic.

  • It creates a hard-coded dependency on a specific label that users are allowed to change.
  • What about sub-ranges, specifically "1 yo" and "2 yo"? Today these ranges don't pose a problem because for both of them StartingRateInPop == 1.0, which is our indicator that prevalence within the population group is not a factor (just the group population).

I don't think we document either of these behaviors: (1) only tasks with RelevantPop == "1-4" are affected by the o_ChildDis_decr flag; and (2) StartingRateInPop == 1.0 turns off prevalence calculations for that task.

Potential solutions:

  1. Document existing behavior and leave it at that.
  2. Create a globalconfig.json setting that identifies "1-4" as the tag for tasks affected by decreasing childhood disease.
  3. Add a new Tasks column which is TRUE if a task is affected by decreasing childhood disease.
@celiot-IDM celiot-IDM added the enhancement New feature or request label Nov 3, 2022
@BHagedorn-IDM
Copy link
Collaborator

Good point. I will write the documentation for this as it is the current behavior. We could add an indicator column to TaskValues for both the o_MHIVTB and o_ChildDis but that makes them actually generic on/off switches and means the names are no longer necessarily applicable, etc. So I'm hesitant to make that change. I'd suggest that we leave as is with documentation for now, and see what our users say.

@celiot-IDM
Copy link
Collaborator Author

Works for me!

BHagedorn-IDM added a commit that referenced this issue Jan 6, 2023
@BHagedorn-IDM
Copy link
Collaborator

Documentation edits made and awaiting merge approval.

MeWu-IDM added a commit that referenced this issue Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants