New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up the various versions of test/sample/etc spreadsheets in use #275

Open

celiot-IDM opened this issue Jun 12, 2023 · 0 comments

Labels

work item

Milestone

V1.1 - PACE-HRH r...

Collaborator

celiot-IDM commented Jun 12, 2023 •

edited

Loading

The PACEHRH package unit tests rely on a bunch of partial versions of the model_inputs spreadsheet. This issue calls out two challenges:

There should always be exactly one "official" version of model_inputs.xlsx, with appropriate version control. Right now Ryan and I are both working on PRs than could change model_inputs.xlsx to add new sheets. Since these are binary files, we can't rely on Git to do clash detection and resolution for us.
Derivative versions for testing need to be identifiable as such to avoid confusion with the official version.

Whatever we decide here should become part of contributor guidelines. (See #276 )

celiot-IDM added the work item label

celiot-IDM added this to the V1.1 - PACE-HRH refresh milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment