Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User-Reported Defect: Improve error handling in SaveBaseSettings #289

Open
MeWu-IDM opened this issue Jul 31, 2023 · 0 comments
Open

User-Reported Defect: Improve error handling in SaveBaseSettings #289

MeWu-IDM opened this issue Jul 31, 2023 · 0 comments
Assignees
Labels
field defect User reported defect

Comments

@MeWu-IDM
Copy link
Collaborator

We received support request from @Nyerere
Describe the defect
When Task target populations does not exist in Lookup, user should get a very clear error message about how to fix it

To reproduce
Steps to reproduce the behavior:

  1. Create a tasks sheet with label "xxx" that is not defined in lookup
  2. Run the scenario that use this task sheet

Expected behavior
A clear error message to let user know how to add population label properly

Actual behavior
https://github.com/InstituteforDiseaseModeling/PACE-HRH/blob/main/pacehrh/R/pace_exp_control.R#L95-L100
(1) it should not be warning but error
(2) message can be improved to show which scenario and some suggestions such as, "did you forget to add the label definition..."

@MeWu-IDM MeWu-IDM added the field defect User reported defect label Jul 31, 2023
@celiot-IDM celiot-IDM self-assigned this Jul 31, 2023
@celiot-IDM celiot-IDM added this to the V1.1 - PACE-HRH refresh milestone Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
field defect User reported defect
Projects
None yet
Development

No branches or pull requests

2 participants