Merge pull request #92 from themrrobert/fix-eco-is-one-move-behind

Fixed: ECO Classification is a move behind
Isarhamster · Jul 1, 2024 · 4a6c1ec · 4a6c1ec
2 parents e3f82ce + e44a185
commit 4a6c1ec
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/src/database/gamex.cpp b/src/database/gamex.cpp
@@ -1739,15 +1739,20 @@ QString GameX::ecoClassify() const
     }
     g.m_moves.moveToEnd();
 
-    //search backwards for the first eco position
-    while(g.m_moves.backward())
+    // Because we now only move backward() after the loop, we must ensure there are some moves
+    if (g.m_moves.countMoves() == 0) {
+        return QString();
+    }
+
+    // Search backwards for the first eco position
+    do
     {
         QString eco;
         if (EcoPositions::isEcoPosition(g.board(),eco))
         {
             return eco;
         }
-    }
+    } while(g.m_moves.backward());
 
     return QString();
 }