Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miss (Parameter 'accountId')) on common PlaceOrderAsync for Huobi #201

Open
heavymanto opened this issue May 23, 2024 · 0 comments
Open

Comments

@heavymanto
Copy link

Describe the bug

Using Houbi PlaceOrderAsync by ISpotClient it raise Exception: One or more errors occurred. (accountId required for Huobi PlaceOrderAsync (Parameter 'accountId'))

Using Houbi client with SpotClient work fine

Unfortunately Huobi also wants accountId as a parameter which obviously is not present as a generic parameter. As an alternative to adding it to the list of parameters since, in a generic wrap, a specific parameter is out of place, you could prepare a generic parameter such as List key/value. This way you can smartly manage the specifics of some Exchanges, without changing the code in the future. What do you say? I would also use this trick on the other methods of the common interface, with default to null, in this way the backward compatibility of the methods that call the interface is guaranteed.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant