Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MVTools functions support #69

Open
5 of 17 tasks
NSQY opened this issue Jan 21, 2023 · 9 comments
Open
5 of 17 tasks

MVTools functions support #69

NSQY opened this issue Jan 21, 2023 · 9 comments

Comments

@NSQY
Copy link
Contributor

NSQY commented Jan 21, 2023

  • Super
  • Analyse
  • Recalculate
  • Compensate
  • Degrain
  • Mask
  • Finest
  • Flow
    • A lesser used function from mvtools. Low priority, I've only ever seen this used once or twice.
      From docs: Do a motion compensation of the frame not by blocks (like MCompensate), but by pixels.
  • FlowBlur
  • FlowInter
  • FlowFPS
  • BlockFPS
  • SCDetection
  • DepanAnalyse
  • DepanEstimate
  • DepanCompensate
  • DepanStabilise
@Setsugennoao Setsugennoao changed the title MFlow support MVTools functions support Jan 26, 2023
@adworacz
Copy link
Contributor

Also note that the latest (git) version of MVTools (not floating point) supports up to Degrain4-6 now. I added it back on new years.

I'm not sure if that requires any code changes in this package, just wanted to give a heads up.

I'm still working on some other (mostly speed) improvements, particularly when working on higher bit depths.

@Setsugennoao
Copy link
Member

Yep i saw your commits. I'll be honest, i didn't update since i didn't want to compile it, and I'm waiting on an official release.

@adworacz
Copy link
Contributor

Totally fair. I hope to have a few more tweaks made in the coming weeks (ideally less), and then I think cutting a new release would be appropriate.

And I looked at the code in this repo. If I'm reading things right, it all should "just work", unless I missed something big. Props to how you've written the code (and the crazy dynamic nature of Python).

@adworacz
Copy link
Contributor

Also @NSQY - It appears that Recalculate support does exist: https://github.com/Irrational-Encoding-Wizardry/vs-denoise/blob/master/vsdenoise/mvtools.py#L770-L772

So you can update the checklist.

@Setsugennoao
Copy link
Member

Totally fair. I hope to have a few more tweaks made in the coming weeks (ideally less), and then I think cutting a new release would be appropriate.

And I looked at the code in this repo. If I'm reading things right, it all should "just work", unless I missed something big. Props to how you've written the code (and the crazy dynamic nature of Python).

Yeah, i will have to update the check of temporal radius from 3 to 6 and hmm i think i'll be it.

@Setsugennoao
Copy link
Member

Also @NSQY - It appears that Recalculate support does exist: https://github.com/Irrational-Encoding-Wizardry/vs-denoise/blob/master/vsdenoise/mvtools.py#L770-L772

So you can update the checklist.

I actually made the checklist based on his initial issue, but i want to have a way of actually manually refining the vector data, I'll have to see and decide the API.

@Setsugennoao
Copy link
Member

Super is now decoupled and can be freely used thanks to @adworacz.

@Setsugennoao
Copy link
Member

Totally fair. I hope to have a few more tweaks made in the coming weeks (ideally less), and then I think cutting a new release would be appropriate.

And I looked at the code in this repo. If I'm reading things right, it all should "just work", unless I missed something big. Props to how you've written the code (and the crazy dynamic nature of Python).

image
Yup, just to confirm, this is the only place where radius support is checked for the int mvtools plugin.

@ghost
Copy link

ghost commented Oct 15, 2023

vs-deinterlace depends on FlowInter, so adding this should be a priority IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants