Refactor/cli change #595
Merged
Refactor/cli change #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeStanger
force-pushed
the
refactor/cli-change
branch
from
146f88b
to
29c9bbd
Compare
This splits most CLI/IPC commands into two categories: - `var` for ironvars - `bar` for controlling individual bars. It also introduces more commands for visibility, as well as breaking existing ones. New commands: - `show` - `hide` - `toggle_visible` - `set_popup_visible` - `get_popup_visible` Lastly, the implementation of some existing commands has been improved. BREAKING CHANGE: All IPC commands have changed. Namely, `type` has been changed to `command`, and bar/var related commands are now under a `subcommand`. The full spec can be found on the wiki. BREAKING CHANGE: Several CLI commands are now located under the `var` and `bar` categories. Usage of any commands to get/set Ironvars or control bar visibility will need to be updated. BREAKING CHANGE: The `open_popup` and `close_popup` IPC commands are now called `show_popup` and `hide_popup` respectively. BREAKING CHANGE: The popup `name` argument has been renamed to `widget_name` on all IPC commands. BREAKING CHANGE: The `set-visibility` CLI command now takes a `true`/`false` positional argument in place of the `-v` flag. BREAKING CHANGE: `ok_value` responses will no longer print `ok` as the first line when using the CLI
JakeStanger
force-pushed
the
refactor/cli-change
branch
from
29c9bbd
to
9dd7112
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits most CLI/IPC commands into two categories:
varfor ironvarsbarfor controlling individual bars.It also introduces more commands for visibility, as well as breaking existing ones.
New commands:
showhidetoggle_visibleset_popup_visibleget_popup_visibleThe implementation of some existing commands has been improved.
The following other smaller features/fixes are introduced by this PR:
BREAKING CHANGE: All IPC commands have changed. Namely,
typehas been changed tocommand, and bar/var related commands are now under asubcommand. The full spec can be found on the wiki.BREAKING CHANGE: Several CLI commands are now located under the
varandbarcategories. Usage of any commands to get/set Ironvars or control bar visibility will need to be updated.BREAKING CHANGE: The
open_popupandclose_popupIPC commands are now calledshow_popupandhide_popuprespectively.BREAKING CHANGE: The popup
nameargument has been renamed towidget_nameon all IPC commands.BREAKING CHANGE: The
set-visibilityCLI command now takes atrue/falsepositional argument in place of the-vflag.BREAKING CHANGE:
ok_valueresponses will no longer printokas the first line when using the CLI