Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/cli change #595

Merged
merged 6 commits into from
Jun 1, 2024
Merged

Refactor/cli change #595

merged 6 commits into from
Jun 1, 2024

Commits on Jun 1, 2024

  1. refactor(popup): rename is_visible to visible

    @JakeStanger
    JakeStanger committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    dedb89b View commit details
    Browse the repository at this point in the history

  2. refactor: make Ironbar#unique_id must_use

    @JakeStanger
    JakeStanger committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    a0cb01a View commit details
    Browse the repository at this point in the history

  3. feat(cli): debug flag

    @JakeStanger
    JakeStanger committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    7413f78 View commit details
    Browse the repository at this point in the history

  4. feat(cli): format flag, json output format

    @JakeStanger
    JakeStanger committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    a33e0a2 View commit details
    Browse the repository at this point in the history

  5. fix(cli): using zero exit code for error responses

    @JakeStanger
    JakeStanger committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    8dda494 View commit details
    Browse the repository at this point in the history

  6. feat!: improve CLI structure, add new commands 

    This splits most CLI/IPC commands into two categories:

- `var` for ironvars
- `bar` for controlling individual bars.

It also introduces more commands for visibility, as well as breaking existing ones.

New commands:

- `show`
- `hide`
- `toggle_visible`
- `set_popup_visible`
- `get_popup_visible`

Lastly, the implementation of some existing commands has been improved.

BREAKING CHANGE: All IPC commands have changed. Namely, `type` has been changed to `command`, and bar/var related commands are now under a `subcommand`. The full spec can be found on the wiki.

BREAKING CHANGE: Several CLI commands are now located under the `var` and `bar` categories. Usage of any commands to get/set Ironvars or control bar visibility will need to be updated.

BREAKING CHANGE: The `open_popup` and `close_popup` IPC commands are now called `show_popup` and `hide_popup` respectively.

BREAKING CHANGE: The popup `name` argument has been renamed to `widget_name` on all IPC commands.

BREAKING CHANGE: The `set-visibility` CLI command now takes a `true`/`false` positional argument in place of the `-v` flag.

BREAKING CHANGE: `ok_value` responses will no longer print `ok` as the first line when using the CLI
    @JakeStanger
    JakeStanger committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    9dd7112 View commit details
    Browse the repository at this point in the history