Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reload bug #599

Merged
merged 1 commit into from
May 19, 2024
Merged

Fix reload bug #599

merged 1 commit into from
May 19, 2024

Conversation

SerraPi
Copy link
Contributor

@SerraPi SerraPi commented May 19, 2024

let index = match index {
    Some(index) => index - 1,
    None => {
        lock!(map).push(monitor_name.clone());
        lock!(map).len() - 1
    }
};

//This causes index to underflow
//Expected Output is something like 0, 1, etc
//But sometimes we go back around to 18446744073709551615

//Removing the index -1 here seems to work ok with multi monitor, and reload is not broken anymore

Fixes #598

    let index = match index {
        Some(index) => index - 1,
        None => {
            lock!(map).push(monitor_name.clone());
            lock!(map).len() - 1
        }
    };

//This causes index to underflow
//Expected Output is something like 0, 1, etc
//But sometimes we go back around to 18446744073709551615

//Removing the -1 here seems to work ok with multi monitor, and reload is not broken anymore
Some(index) => index,
@SerraPi SerraPi changed the title Fix main.rs Fix reload bug May 19, 2024
@JakeStanger JakeStanger merged commit 4ad4b0e into JakeStanger:master May 19, 2024
8 checks passed
@SerraPi SerraPi deleted the patch-1 branch May 20, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ironbar reload does no longer work on git builds
2 participants