Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Schedule Excel File Upload Lenient #12

Open
slominskir opened this issue Nov 22, 2023 · 0 comments
Open

Make Schedule Excel File Upload Lenient #12

slominskir opened this issue Nov 22, 2023 · 0 comments

Comments

@slominskir
Copy link
Member

slominskir commented Nov 22, 2023

There are a few improvements to leniency that could be implemented for the Excel file parser including:

  • Program names sometimes have extraneous spaces - add trim() function before compare
  • Program names often are capitalized differently - add upper() function before compare
  • Program names often use aliases (INSTALL vs INSTALLATION) - create import_alias_csv column?

Further, the "official" program names are often just whatever Javier originally included in the first Excel upload, but they're capitalized inconsistently - perhaps make all program names ALL CAPS or All Titlecase or all lowercase.

Official program names displayed on the schedule also include more than may be helpful / useful given audience of accelerator ops. Many activities such as Install and Commissioning map to OFF as far as time accounting goes. It may just be creating confusion as ops/ PD is required to do this mental program conversion themselves. We could map these programs to OFF automatically. Perhaps add an extra OFF_ACTIVITY column or something with the details for those who are interested.

There are other common restrictions we may be able to make more lenient such:

  • Months must start at day 1 - we could make the parser automatically fill in OFF days leading up to given day.
  • Spurious comments in columns that are supposed to be empty due to program being "OFF" and that normally contain specially formatted data if not OFF - this one is a little dangerous, but we could default to ignore instead of throw error as is done now.

"Pass change" is tricky with time accounting as it's treated as an ACCELERATOR activity by Crew Chiefs and as a PHYSICS activity by Experimenters - more specifically Crew Chiefs set halls to OFF during pass changes while Experimenters have a special ACC metric they are supposed to use. Probably just stays as is on the schedule.

"Reconfigure" may need clarification else leave as is. It could possibly fall under "Hall Procedure", however those generally aren't scheduled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant