From de64d43c158d6cdd23d59424d8e682390462a2ce Mon Sep 17 00:00:00 2001 From: Abdelilah El Aissaoui Date: Tue, 9 Jan 2024 14:42:45 +0100 Subject: [PATCH] Fixed header drag in log being too fast in hight density displays --- .../gitnuro/ui/components/SideMenuPanel.kt | 48 ------------------- .../com/jetpackduba/gitnuro/ui/log/Log.kt | 2 +- 2 files changed, 1 insertion(+), 49 deletions(-) delete mode 100644 src/main/kotlin/com/jetpackduba/gitnuro/ui/components/SideMenuPanel.kt diff --git a/src/main/kotlin/com/jetpackduba/gitnuro/ui/components/SideMenuPanel.kt b/src/main/kotlin/com/jetpackduba/gitnuro/ui/components/SideMenuPanel.kt deleted file mode 100644 index ea88caf5..00000000 --- a/src/main/kotlin/com/jetpackduba/gitnuro/ui/components/SideMenuPanel.kt +++ /dev/null @@ -1,48 +0,0 @@ -package com.jetpackduba.gitnuro.ui.components - -import androidx.compose.foundation.layout.Column -import androidx.compose.foundation.layout.fillMaxWidth -import androidx.compose.runtime.Composable -import androidx.compose.ui.Modifier -import androidx.compose.ui.graphics.painter.Painter -import com.jetpackduba.gitnuro.ui.context_menu.ContextMenu -import com.jetpackduba.gitnuro.ui.context_menu.ContextMenuElement - -@Composable -fun SideMenuPanel( - title: String, - icon: Painter? = null, - items: List, - isExpanded: Boolean = false, - onExpand: () -> Unit, - itemContent: @Composable (T) -> Unit, - headerHoverIcon: @Composable (() -> Unit)? = null, - contextItems: () -> List = { emptyList() }, -) { - VerticalExpandable( - isExpanded = isExpanded, - onExpand = onExpand, - header = { - ContextMenu( - items = contextItems - ) { - SideMenuHeader( - text = title, - icon = icon, - itemsCount = items.count(), - hoverIcon = headerHoverIcon, - isExpanded = isExpanded, - ) - } - }, - ) { - Column( - modifier = Modifier - .fillMaxWidth() - ) { - for (item in items) { - itemContent(item) - } - } - } -} \ No newline at end of file diff --git a/src/main/kotlin/com/jetpackduba/gitnuro/ui/log/Log.kt b/src/main/kotlin/com/jetpackduba/gitnuro/ui/log/Log.kt index a81fdaef..97f965b7 100644 --- a/src/main/kotlin/com/jetpackduba/gitnuro/ui/log/Log.kt +++ b/src/main/kotlin/com/jetpackduba/gitnuro/ui/log/Log.kt @@ -595,7 +595,7 @@ fun GraphHeader( SimpleDividerLog( modifier = Modifier.draggable( rememberDraggableState { - onPaddingChange(it * density) // Multiply by density for screens with scaling > 1 + onPaddingChange(it / density) // Divide by density for screens with scaling > 1 }, Orientation.Horizontal ), )