Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wither Bones don't drop if Hephaestus (TConstruct) is installed, but Red Heart Canister recipe is hardcoded to use BHC Wither Bones #4

Closed
unilock opened this issue Jul 1, 2024 · 2 comments

Comments

@unilock
Copy link

unilock commented Jul 1, 2024

BHC's Wither Bones don't drop from Wither Skeletons if "tconstruct" (a.k.a. Hephaestus on Fabric) is installed, as seen here in DropHandler:

if (!FabricLoader.getInstance().isModLoaded("tconstruct") && entity instanceof WitherSkeletonEntity) {

However, the Red Heart Canister recipe is hardcoded to use BHC's Wither Bones, instead of, say, a tag containing both BHC's Wither Bones and Hephaestus's Necrotic Bones:

This makes the Red Heart Canister impossible to craft with Hephaestus installed.

@JongWasTaken
Copy link
Owner

Hello, and thank you for reporting this issue.

Unfortunately I don't have a working internet connection right now, and cannot push a fix because of it.

If possible (and if you care enough), could you create a PR for this? Otherwise the earliest date at which I could fix this would be the 5th.

Either way, have a good day!

@JongWasTaken
Copy link
Owner

Thanks to finally having internet again, I was able to build and publish 1.0.5 today.

The usual Modrinth/CurseForge stuff applies, and this issue can finally be closed.
Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants