Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git automatically converts EOL newlines #216

Closed
Paalon opened this issue Jun 19, 2024 · 5 comments · Fixed by #235
Closed

Git automatically converts EOL newlines #216

Paalon opened this issue Jun 19, 2024 · 5 comments · Fixed by #235

Comments

@Paalon
Copy link
Contributor

Paalon commented Jun 19, 2024

Git convert EOL newlines for operating systems perhaps in default. For easy debugging and testing, we should prohibit it by setting.

Complement: it was misleading, I want to say, we should be explicit whether CRLF or LF for input YAML files of our tests.

@GunnarFarneback
Copy link
Contributor

I'm not so sure about that since it would increase the risk that we fail to find Windows specific problems during testing and that they turn up in the wild instead.

@Paalon
Copy link
Contributor Author

Paalon commented Jun 19, 2024

Then, we'll just add tests for the CRLF version of all LF tests.

@GunnarFarneback
Copy link
Contributor

That doesn't sound like a good idea for DRY reasons. I think Windows CI is good enough to capture problems but if we want to run CRLF tests on Linux/Mac, the way to do that is to create CRLF versions of the files on the fly while running the tests.

@kescobo
Copy link
Collaborator

kescobo commented Jun 26, 2024

related to #232

@GunnarFarneback
Copy link
Contributor

the way to do that is to create CRLF versions of the files on the fly while running the tests.

Implemented in #235.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants