-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add rule for copy #472
base: main
Are you sure you want to change the base?
add rule for copy #472
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Do you know why the Zygote integration is failing? Seems to be some higher order AD thing?
no idea why Zygote is failing |
Codecov Report
@@ Coverage Diff @@
## master #472 +/- ##
=======================================
Coverage 98.12% 98.13%
=======================================
Files 22 22
Lines 2350 2353 +3
=======================================
+ Hits 2306 2309 +3
Misses 44 44
Continue to review full report at Codecov.
|
Should this be here or in Zygote? i.e. is this a mathematical property of Within Zygote, Finally, testing this by finite-differences doesn't achieve much. But testing that it does what you want on a Not much of a review, but maybe things to think about. |
I would say it is a convention of the language, the Base's docstring reads
agree
|
I think we should do this. But the Zygote error in "nested AD hitting identity(::Tuple) pullback " is weird. |
Fixes FluxML/Zygote.jl#1037