Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow grid to start at non-zero value #37

Open
CNelias opened this issue Oct 23, 2019 · 3 comments
Open

Allow grid to start at non-zero value #37

CNelias opened this issue Oct 23, 2019 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@CNelias
Copy link
Member

CNelias commented Oct 23, 2019

The current version of quantize() excpects a grid to start at 0 and end at 1.

Some players have a systematics deviation, and removing them makes the music sound strange. It would be good to be able to use grids like [0.09,0.33,0.7,1] for example.

@Datseris Datseris added enhancement New feature or request help wanted Extra attention is needed labels Oct 23, 2019
@Datseris
Copy link
Member

Although this is a straightforward improvement, a workaround currently is to use the function estimate_delay and estimate_delay_recursive, and shift the notes, then quantize them and then shift them back.

@CNelias
Copy link
Member Author

CNelias commented Oct 23, 2019

The workaround is quite trivial indeed, but I'd like to have this feature inside of quantize. I'll see if can implement it today if it's not too complicated.

@Datseris
Copy link
Member

Datseris commented Oct 23, 2019

@johncwok , what does 1 mean in [0.09,0.33,0.7,1]? Does it mean the next quarter note? then what does 0.09 mean?

I see some difficulties of how your suggestion of not starting at 0 and not ending at 1 can work with quantize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants