Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter names in rheological models are slightly inconsistent #127

Open
akabla opened this issue Jul 27, 2021 · 1 comment
Open

Parameter names in rheological models are slightly inconsistent #127

akabla opened this issue Jul 27, 2021 · 1 comment
Labels
enhancement New feature or request seeking opinions
Milestone

Comments

@akabla
Copy link
Member

akabla commented Jul 27, 2021

There are a few issues we can try to address in future versions.

  • We use G for the generalised and empirical model, but k elsewhere.

  • The subscript alpha does not exist in unicode, so we have a naming that is not very intuitive, with a and c_a for the first springpot, but \beta and c_\beta for the other one. I think we should avoid using subscripts with greek letters. They are hard to read and hard to type.

We now have a translation table for model symbols, so we can accepts many different syntax and avoid breaking changes. I just think that the default should be systematic, as much as possible.

@akabla akabla added this to the 0.9.5 milestone Jul 27, 2021
@akabla akabla added enhancement New feature or request seeking opinions labels Jul 27, 2021
@moustachio-belvedere
Copy link
Member

May be of interest, but it's a long way out stevengj/subsuper-proposal#10

@akabla akabla modified the milestones: 0.9.5, 0.9.6 Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request seeking opinions
Projects
None yet
Development

No branches or pull requests

2 participants