Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of variable sample-rate fitting? #151

Open
moustachio-belvedere opened this issue Dec 15, 2021 · 0 comments
Open

Status of variable sample-rate fitting? #151

moustachio-belvedere opened this issue Dec 15, 2021 · 0 comments
Labels
breaking A change in syntax that would make syntax of older versions break seeking opinions
Milestone

Comments

@moustachio-belvedere
Copy link
Member

Creating this issue to track status of variable sample-rate fitting changes. My (vague) memory of our last group discussions on this is that we should consider getting rid of variable sample rate fitting due its inaccuracy and slowness, replacing it with coercion of user data to constant sample rate.

First decision to make is whether we get rid of it completely or we just have more warnings like:
https://github.com/JuliaRheology/RHEOS.jl/blob/master/src/base.jl#L574
in other relevant places and the documentation.

@akabla akabla added seeking opinions breaking A change in syntax that would make syntax of older versions break labels Jan 4, 2023
@akabla akabla added this to the 1.0.0 milestone Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking A change in syntax that would make syntax of older versions break seeking opinions
Projects
None yet
Development

No branches or pull requests

2 participants