Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve checks for existence of moduli/compliance expressions #73

Open
3 tasks
akabla opened this issue May 30, 2020 · 0 comments
Open
3 tasks

Improve checks for existence of moduli/compliance expressions #73

akabla opened this issue May 30, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@akabla
Copy link
Member

akabla commented May 30, 2020

This follows up from #52

Fields could be missing in the model definitions and the default value returned by the moduli/compliance functionwrappers is NaN, which seems appropriate.

  • We may want to reconsider how the "modulusexists" function works though. This utility function could look into the "expressions" named tuple as part of the RheoModelClass object and determine then if the modulus is defined, rather than evaluating the function.

  • processing.jl would need to be updated.

  • The external moduli/compliance functions could also check and send an error where appropriate.

@akabla akabla added the enhancement New feature or request label May 30, 2020
@akabla akabla added this to the 1.0.0 milestone May 30, 2020
@akabla akabla self-assigned this May 30, 2020
@moustachio-belvedere moustachio-belvedere changed the title Improve checks for existence of moduli/complience expressions Improve checks for existence of moduli/compliance expressions Jan 5, 2021
@akabla akabla modified the milestones: 1.0.0, 0.9.5 Aug 18, 2021
@akabla akabla modified the milestones: 0.9.5, 0.9.6 Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant