Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding linter/formatter action for consistent code style #89

Open
moustachio-belvedere opened this issue Jun 18, 2020 · 2 comments
Milestone

Comments

@moustachio-belvedere
Copy link
Member

We may want to consider adding this Github linter action once Julia formatting becomes available, to increase the style consistency of the repo:

https://github.blog/2020-06-18-introducing-github-super-linter-one-linter-to-rule-them-all/

Could be part of the longer term plan to move docs building to Github actions.

@moustachio-belvedere
Copy link
Member Author

Adding some links here in case any others want to play around with this.

Link below seems like a pretty useful GitHub action which creates a PR for suggested formatting code changed automatically:

https://github.com/julia-vscode/DocumentFormat.jl/blob/master/.github/workflows/jlpkgbutler-codeformat-pr-workflow.yml

Though the most popular Julia formatter (by github stars) appears to be this one:

https://github.com/domluna/JuliaFormatter.jl

I'm also experimenting with this linter:

https://github.com/julia-vscode/StaticLint.jl

@moustachio-belvedere moustachio-belvedere changed the title Consider adding Github linter action for consistent code style Consider adding linter/formatter action for consistent code style Jan 4, 2021
@akabla
Copy link
Member

akabla commented Aug 18, 2021

@moustachio-belvedere I like JuliaFormatter.jl. Could be useful, especially with the Vim plugin!

@akabla akabla added this to the 0.9.5 milestone Aug 18, 2021
@akabla akabla modified the milestones: 0.9.5, 0.9.6 Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants