feat: ordering of only relevant loops(no visual) #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asyms
reviewed
Feb 1, 2024
| o = h | ||
| l = [] | ||
| while o is not None: | ||
| l.append(o.value) | ||
| o = o.next | ||
| return l | ||
| # place unordered loops at the end | ||
| return [(name,size) for name,size in original_multiset if name in unordered_loops]+l |
There was a problem hiding this comment.
Does this not place the "unordered loops" at the start (i.e. innermost loops) of the permutation? As opposed to "at the end" as you state in the PR?
|
Hi, thank you for the question, they are placed as the innermost ones (so at the end of the computation, where the tensors should be allocated already at innermost memory level) |
asyms
requested changes
Feb 23, 2024
There was a problem hiding this comment.
I'm not entirely sure how you would use this. Can you add some test scenarios that use it in a way in a new folder here: https://github.com/KULeuven-MICAS/zigzag/tree/master/tests/main ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional parameter that can be received on a layer that defines a set of loop to be left unordered
Blocking loop factorization and ordering of such loops
(no update to the visual bar yet)