Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Better loading of media #103

Open
KnugiHK opened this issue Jun 30, 2024 · 1 comment
Open

[FEATURE] Better loading of media #103

KnugiHK opened this issue Jun 30, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request pending for release Feature or bug fix to be released

Comments

@KnugiHK
Copy link
Owner

KnugiHK commented Jun 30, 2024

Discussed in #90

@jonx suggested:

I'm not a web developer but I did some quick research and maybe all we need to get the lazy loading is add a tag to the images as documented here: https://www.w3schools.com/tags/att_img_loading.asp
Only Safari doesn't handle this tag.

<img src="Media/Profile\33610007857-1665000879.thumb" loading="lazy" class="avatar">

Also while commenting on things that I don't really know, maybe you could consider using the base tag in your HTML? Maybe you have a reason not to use it or maybe it's just me but my links are pretty long like this:
<a href="AppDomainGroup-group.net.whatsapp.WhatsApp.shared/Media/Profile\6590002603-1700006881.thumb"><img src="AppDomainGroup-group.net.whatsapp.WhatsApp.shared/Media/Profile\6590002603-1700006881.thumb" onerror="this.style.display='none'" class="avatar"></a>
with the base tag like this:
<base href="AppDomainGroup-group.net.whatsapp.WhatsApp.shared/">
you should be able to shorten the URLs to this:
<img src="Media/Profile\33610007857-1665000879.thumb">

@KnugiHK KnugiHK added the enhancement New feature or request label Jun 30, 2024
@KnugiHK KnugiHK self-assigned this Jun 30, 2024
KnugiHK added a commit that referenced this issue Jun 30, 2024
@KnugiHK
Copy link
Owner Author

KnugiHK commented Jun 30, 2024

@jonx Thanks for your suggestions! The improvement has been made to the dev branch and will be release later.

@KnugiHK KnugiHK added the pending for release Feature or bug fix to be released label Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pending for release Feature or bug fix to be released
Projects
None yet
Development

No branches or pull requests

1 participant