-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for Legrand 067761A #7288
base: master
Are you sure you want to change the base?
Conversation
Could you try with the generated external converter instead? Try this with the 1 April release tomorrow. |
What is the difference supposed to be? Would that be better? I tried to stick to the way Legrand devices work. |
It does not seem that it detected anything really useful 🤷 const {batteryPercentage, identify} = require('zigbee-herdsman-converters/lib/modernExtend');
const definition = {
zigbeeModel: [' Remote fan controller'],
model: ' Remote fan controller',
vendor: ' Legrand',
description: 'Automatically generated definition',
extend: [batteryPercentage(), identify()],
meta: {},
};
module.exports = definition |
I've recently added necessary modern extends and they will be in release version soon. It is strongly advised to use them instead of older split style converters. |
As @mrskycriper mentioned, try again with the 1.36.1 release. This will generate more clean code. |
Sure 👍 |
Hi all, While the advantages of ModernExtends are obvious, what are the intentions on the long run ? Legrand devices are somewhat different, in that they do not "always" follow standards. To address this, we've implemented those quirks in vendor specific libs so far. While not ideal, this decouples those features from the "generic" implementation. How should we address this best in future ? Thanks a lot for your insights. |
Generated code with latest: const {identify, battery, commandsOnOff, commandsLevelCtrl} = require('zigbee-herdsman-converters/lib/modernExtend');
const definition = {
zigbeeModel: [' Remote fan controller'],
model: ' Remote fan controller',
vendor: ' Legrand',
description: 'Automatically generated definition',
extend: [identify(), battery(), commandsOnOff(), commandsLevelCtrl()],
meta: {},
};
module.exports = definition; Is that better? |
@Diaoul if it works, please update the PR with it. |
Add support for Legrand 067761A
Questions
genLevelCtrl
but in the context of this particular switch I think it's not supposed to work. Anyways, if I want to add support for it, what should I do? The closest I found isbrightness_move_up
which is very far from what this is supposed to do 😅Wireless remote switch
from Legrand as well as it's on the NLT device list from here