Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect spec for Api.modify_webhook #612

Open
malmz opened this issue Jul 6, 2024 · 3 comments
Open

Incorrect spec for Api.modify_webhook #612

malmz opened this issue Jul 6, 2024 · 3 comments

Comments

@malmz
Copy link

malmz commented Jul 6, 2024

The spec for Api.modify_webhook does not match discords documentation

  • name and avatar are required while they should be optional
  • channel_id is missing .

https://discord.com/developers/docs/resources/webhook#modify-webhook

@Th3-M4jor
Copy link
Contributor

Nostrum's API module is mostly a low level pass-through to discord with minimal transformations applied before encoding the payload into JSON. As such it kinda assumes you're using it in tandem with Discord's own API docs, so any specs you see are usually little more than a guideline.

PRs to fix any inconsistencies are always welcome though 🙂

@broman
Copy link

broman commented Jul 6, 2024

Understood, thanks Th3-M4jor!

@broman
Copy link

broman commented Jul 6, 2024

I love Nostrum!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants