Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test rules #22

Closed
hmuniz opened this issue Mar 16, 2017 · 8 comments
Closed

Test rules #22

hmuniz opened this issue Mar 16, 2017 · 8 comments

Comments

@hmuniz
Copy link
Contributor

hmuniz commented Mar 16, 2017

In 4dca2b I solved the merge conflict and tested the corte-e-costura function.

The test was done using this conllu file and these rules:

(=> ((?a (= upostag "ADV") (= lemma "além"))
     *
     (?b (= lemma "ter")))
    ((?b (+ lemma "============"))))

(=> (?a (= lemma "liberdade") (= upostag "NOUN"))
    (?a (! upostag "===========")))

(=> ((?a (= lemma "trabalho"))
     ?
     (?b (= lemma "passar"))
     ?
     (?c (= lemma "em")))
    ((?a (! lemma "============"))))
@arademaker
Copy link
Contributor

arademaker commented Mar 16, 2017

Não entendi o operador ?, o * quer dizer "um ou mais tokens" mas o ? ? Ele refere-se à opcionalidade do token anterior ou posterior? A notação não está boa.

@GPPassos
Copy link
Contributor

I'm sorry, but what is the issue here? Is this just a report on what was done?

@arademaker
Copy link
Contributor

Yes, @GPPassos , @hmuniz should have had created the issue before the code and report the evolution here, but since he didn't do it, I asked him to open the issue anyway. Github does not send alerts for commits, only for updates in the issues.

@GPPassos
Copy link
Contributor

Oh, no problem! It'd just be good to have a brief description of the problem as well in order to have a record

@arademaker
Copy link
Contributor

I agree

@GPPassos
Copy link
Contributor

GPPassos commented Apr 3, 2017

@hmuniz Sorry if it's a silly question, but on https://github.com/own-pt/cl-conllu/blob/4dca2bd80734df85ef30b94b226892cd78b10a68/rules.lisp#L9 what do rls and rhs stand for?
I'd think that rhs means "right-hand side", but then instead of rls shouldn't it be lhs (left-hand side)?

@arademaker
Copy link
Contributor

the corte-costura based rules were implemented, but I believe #50 can be more useful in the future. Anyway, it seems this issue was already solved.

@arademaker
Copy link
Contributor

implemented by @Kalysthos closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants