Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaner boundaries between libertem-specific code and the rest #5

Open
sk1p opened this issue Feb 5, 2020 · 4 comments
Open

Cleaner boundaries between libertem-specific code and the rest #5

sk1p opened this issue Feb 5, 2020 · 4 comments
Milestone

Comments

@sk1p
Copy link
Member

sk1p commented Feb 5, 2020

Modules imported from the main libertem package, which will become "de-facto public" interfaces (meaning we will have to coordinate changes to these interfaces with libertem_blobfinder):

  • libertem.masks
  • libertem.analysis.gridmatching: used for frame visualization and refinement
  • libertem.common.container: MaskContainer used in the SparseCorrelationUDF
  • libertem.utils for frame_peaks
@sk1p sk1p added this to the 0.5 milestone Feb 5, 2020
@sk1p
Copy link
Member Author

sk1p commented Feb 5, 2020

Also, which parts of the blobfinder don't need to depend on libertem, which can be made more reusable?

This was referenced Feb 5, 2020
@sk1p sk1p changed the title More clean boundaries between libertem-specific code and the rest Cleaner boundaries between libertem-specific code and the rest Feb 5, 2020
@uellue
Copy link
Member

uellue commented Feb 11, 2020

The separation was now done in #14. Yes, managing the net of dependencies will be a bit of work while the restructuring is ongoing. All the packages you mention are candidates to become indedependent of LiberTEM core.

@sk1p sk1p modified the milestones: 0.5, 0.6 May 8, 2023
@sk1p
Copy link
Member Author

sk1p commented Apr 16, 2024

At least the clean separation of the core correlation code from the libertem-dependent part is done as of #87 + #90

@sk1p
Copy link
Member Author

sk1p commented Apr 18, 2024

I consider this done for now, further restructuring is separate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants