Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use newtypes instead of strings in apis for name vs id et #324

Open
lakinwecker opened this issue May 6, 2020 · 0 comments
Open

Use newtypes instead of strings in apis for name vs id et #324

lakinwecker opened this issue May 6, 2020 · 0 comments

Comments

@lakinwecker
Copy link
Collaborator

For example, we should have a SlackChannelID and SlackChannelName and SlackUserName and SlackUserID, and LIchessUsername and LichessUserId.

This way we aren't screwing them constantly (which I was).

New types can be implemented with: https://github.com/gcanti/newtype-ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant