Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aes_encrypt duplicate definition linking error + ideas for fix #68

Open
cmorganBE opened this issue Jun 24, 2024 · 1 comment
Open

aes_encrypt duplicate definition linking error + ideas for fix #68

cmorganBE opened this issue Jun 24, 2024 · 1 comment

Comments

@cmorganBE
Copy link

aes_encrypt() symbol is a common one, wolfssl and/or some other ssl modules appear to define the same symbol.

Would it be acceptable to rename the public functions in aes.h to add a 'lora_' prefix? like lora_aes_encrypt()?

If so I can open a PR with said change.

I'm guessing there may be ways to fix this with various build options but that seemed like a significant amount of additional effort, although fewer changes to the stack here.

Thoughts? We'd like to not carry any local changes around (and today we've renamed aes_encrypt() to lora_aes_encrypt() to resolve this issue).

@opeyrard
Copy link

Hi,
We will evaluate feasibility for the next release.
Many thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants