Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.

Make "editAudio" method faster. #15

Open
nbtpApp opened this issue Jan 9, 2022 · 2 comments
Open

Make "editAudio" method faster. #15

nbtpApp opened this issue Jan 9, 2022 · 2 comments
Labels
Extra: Feature New feature or request PRI: High Needs to be resolved sooner than other issues (Critical to plugin function) S: To-Do Feature or request that still need doing

Comments

@nbtpApp
Copy link

nbtpApp commented Jan 9, 2022

Since I am developing on android 11, when using the "editAudio" method, I call "requestComplexPermission" to specify the folder, and set searchInsideFolders to ture.

The "editAudio" method succeeds in a small test folder (whit a few song Files).
However, for large folders, it takes a very long time (about 1 minute) and the operation is unstable.
(My music library has 6500 music files, which is about 60GB in size.)

Is this the correct behavior?

@LucJosin
Copy link
Owner

Hi @nbtpApp. I noticed this issue when creating this plugin and using with 1000+ files. After some research i found the problem.

As you notice, to be able to use this plugin with Android 11 we need request a special permission (requestComplexPermission) and this plugin uses the official DocumentFile framework. And, for some reason, some of methods are too slow.

Some months ago i didn't find nothing to fix this issue but now DarShan created something simillar and with a good performance. I'll try to use it.

@LucJosin LucJosin added Extra: Feature New feature or request PRI: High Needs to be resolved sooner than other issues (Critical to plugin function) S: To-Do Feature or request that still need doing labels Jan 10, 2022
@nbtpApp
Copy link
Author

nbtpApp commented Jan 10, 2022

Thank you for working on this issue.
It was good that a clue to the solution was found.
I hope this plugin will be improved.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Extra: Feature New feature or request PRI: High Needs to be resolved sooner than other issues (Critical to plugin function) S: To-Do Feature or request that still need doing
Projects
None yet
Development

No branches or pull requests

2 participants