Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

textClickFuncs should be moved to its own file #16

Open
Logodaedalus opened this issue Dec 17, 2018 · 0 comments
Open

textClickFuncs should be moved to its own file #16

Logodaedalus opened this issue Dec 17, 2018 · 0 comments
Labels
enhancement New feature or request timeline view Issues related to timeline view

Comments

@Logodaedalus
Copy link
Contributor

Logodaedalus commented Dec 17, 2018 •
edited
Loading

Currently textClickFuncs lives ~line 295 in Display.js, and contains all the click functions bound to shimmer wishlist text. Instead it should live in its own file.

We can keep the syntax of {shimmer|shimmerFunctionName|initialValue} inline for scene descriptions...that's pretty good.
@Logodaedalus Logodaedalus added enhancement New feature or request timeline view Issues related to timeline view labels Dec 17, 2018
@Logodaedalus Logodaedalus changed the title textClickFuncs should be moved to config files textClickFuncs should be moved to its own file Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request timeline view Issues related to timeline view
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Logodaedalus