Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Submissions Tables with Date and Username #2074

Closed
gmeben opened this issue Mar 8, 2024 · 4 comments · Fixed by #2105 or #2084
Closed

Update Submissions Tables with Date and Username #2074

gmeben opened this issue Mar 8, 2024 · 4 comments · Fixed by #2105 or #2084
Assignees
Labels
💍 feature New feature or request 🖥️ frontend Related to the Vue/JS portions

Comments

@gmeben
Copy link
Contributor

gmeben commented Mar 8, 2024

Currently, submissions presented within submission tables don't show when they were submitted or by whom. Publication Names has a column, which may not be useful to Pilcrow instances where only one publication will exist.

Add the following columns to Submission Tables:

  • Submitted By: with a value of the name or username of the user who is listed as the submitter
  • Submitted On: with a relative timestamp of when the submission was submitted

Review Checklist

  • Columns to submission tables are added
  • Necessary frontend unit testing has been added

Accessibility Checklist

  • No new color contrast issues are introduced
  • Changed text has a font size of at least 16px
  • Changed text uses plain language
@gmeben gmeben added 🧹 needs-refinement Issues that need more detail in order to be ready for work to commence 💍 feature New feature or request 🖥️ frontend Related to the Vue/JS portions ❓ question Further information is requested and removed 🧹 needs-refinement Issues that need more detail in order to be ready for work to commence labels Mar 8, 2024
@gmeben
Copy link
Contributor Author

gmeben commented Mar 8, 2024

The added columns are likely going to make it so that the width of submission tables will exceed the viewports of devices most of the time, making the "Actions" column only accessible with horizontal scrolling.

Question for this issue:

  1. Does it make sense to add functionality that allows a user to specify which columns are visible?
    • Pros: users are empowered by the interface, table-width problems are eliminated
    • Cons: could be costly to design and implement appropriate components, existing tests will need to be updated
    • This could be done by:
      • Storing this preference information in the database
        • Pro: user preferences are saved regardless of device accessing Pilcrow
        • Con: somewhat costly in that an appropriate database schema will need to be designed and implemented
      • Using cookies and storing this preference information client-side
        • Pros: relatively inexpensive to implement
        • Cons: user preferences are relative to the device accessing Pilcrow, has GDPR concerns because cookies are being used

@gmeben
Copy link
Contributor Author

gmeben commented Mar 8, 2024

@sattler9
Copy link
Contributor

Hey team! Please add your planning poker estimate with Zenhub @gmeben @vilagshe @wreality

@gmeben
Copy link
Contributor Author

gmeben commented Mar 25, 2024

A separate issue will be created to address any reflow problems or empowering users to modify the appearance of the interface with regard to submission tables.

Edit: That issue is #2104

@gmeben gmeben removed the ❓ question Further information is requested label Apr 4, 2024
@gmeben gmeben self-assigned this Apr 4, 2024
gmeben added a commit that referenced this issue Apr 10, 2024
This pull request adds the columns "Submitted By" and "Submitted" to submission tables. It also adds the missing submission link on narrower "mobile" viewports.

Closes #2074
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💍 feature New feature or request 🖥️ frontend Related to the Vue/JS portions
Projects
None yet
2 participants