fixing reflist + adding test for Git2\Reference::list($repo)

MagicalTux · Nov 21, 2017 · 87e3f4f · 87e3f4f
1 parent 32d63a2
commit 87e3f4f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/git2_reference.c b/git2_reference.c
@@ -82,14 +82,13 @@ ZEND_END_ARG_INFO()
 
 static int git2_reference_list_callback(git_reference *ref, void *payload) {
 	git2_reference_object_t *intern;
-	zval *obj;
-	ALLOC_ZVAL(obj);
+	zval obj;
 
-	object_init_ex(obj, php_git2_reference_ce);
-	intern = (git2_reference_object_t*)Z_OBJ_P(obj);
+	object_init_ex(&obj, php_git2_reference_ce);
+	intern = (git2_reference_object_t*)Z_OBJ_P(&obj);
 	intern->ref = ref;
 
-	add_next_index_zval((zval*)payload, obj);
+	add_next_index_zval((zval*)payload, &obj);
 	return 0;
 }
 
@@ -108,7 +107,7 @@ static PHP_METHOD(Reference, list) {
 
 	array_init(return_value);
 
-	int res = git_reference_foreach(repo, git2_reference_list_callback, &return_value);
+	int res = git_reference_foreach(repo, git2_reference_list_callback, return_value);
 	if (res != 0) {
 		git2_throw_last_error();
 		return;

diff --git a/git2_tests/001_clone.php b/git2_tests/001_clone.php
@@ -13,3 +13,7 @@
 #var_dump($repo->checkout_head());
 var_dump($repo->head());
 
+foreach(Git2\Reference::list($repo) as $ref) {
+	echo "Ref: ".$ref->name()." --> ".bin2hex($ref->target())."\n";
+}
+