Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demo app doesn't build #83

Closed
BigAppsAndroid1 opened this issue May 16, 2023 · 4 comments
Closed

demo app doesn't build #83

BigAppsAndroid1 opened this issue May 16, 2023 · 4 comments

Comments

@BigAppsAndroid1
Copy link

try to build demo app "as is" in emulator iPhone 14 Pro Max without success.

Failed to build iOS app
Error (Xcode): ../../../.pub-cache/hosted/pub.dev/preload_page_view-0.1.6/lib/preload_page_view.dart:179:15: Error: The method 'PageMetrics.copyWith' doesn't have the named parameter 'devicePixelRatio' of overridden method 'Object with ScrollMetrics.copyWith'.
@jmgeffroy
Copy link
Contributor

jmgeffroy commented May 16, 2023

Hi @BigAppsAndroid1, That's surprising; I just tried again, and it works (screenshot attached). Can you please check that you're on the "main" branch?

EDIT: Maybe that's related to your Flutter version. I'm currently on 3.7.12.

Capture d’écran 2023-05-16 à 18 37 38

@Damianoux
Copy link

I can confirm that the problem occours when upgrading from 3.7.12 to 3.10.
The devicePixelRatio parameter is now required.
Maybe some of the libraries used need to be updated.
A quick fix is to downgrade to 3.7.12. go to the directory wehe flutter is installed and run "git checkout 3.7.12".

@jmgeffroy
Copy link
Contributor

Hi @Damianoux, Yes, absolutely. I have started migrating to Flutter 3.10, which implies migrating to Dart 3. Since many parts of Iridium depend on dfunc, we must migrate the use of Product (--> D3 records), Coproduct (--> D3 sealed classes), and Either (--> D3 sealed classes + pattern matching). Work in progress.
See ookami-kb/dfunc#25 and https://github.com/ookami-kb/dfunc/pull/25/commits

@jmgeffroy
Copy link
Contributor

Dart 3 Migration complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants