Venue handling refactor #382
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fice venue as default prop.
…nally when the Map Template switches venue.
…o the useCurrentVenue hook where it belongs.
…entVenue hook, since it is a side effect of venue changes.
…nfusing to have a state for both the venue name and the actual venue.
…d not change the map.
…ng issues with the JavaScript SDK.
Comment on lines
123
to
125
| * When map position is known, run callback. | ||
| */ | ||
| useEffect(() => { |
There was a problem hiding this comment.
Should we update the description here?
There was a problem hiding this comment.
I'll see to it.
Comment on lines
131
to
135
| /* | ||
| * When venue is changed on the map, run callback. | ||
| * Set the current venue name whenever the venue is changed on the map. | ||
| */ | ||
| useEffect(() => { |
There was a problem hiding this comment.
Should update the description here as well based on the new logic
| @@ -74,23 +69,18 @@ const useMapBoundsDeterminer = () => { | |||
| */ | |||
| useEffect(() => { | |||
| determineMapBounds(); | |||
| }, [mapsIndoorsInstance, venue, venues, locationId, kioskOriginLocationId, pitch, bearing, startZoomLevel, categories]); | |||
| }, [mapsIndoorsInstance, currentVenueName, locationId, kioskOriginLocationId, pitch, bearing, startZoomLevel, categories]); | |||
|
|
|||
| /** | |||
| * Based on the combination of the states for venueName, locationId & kioskOriginLocationId, | |||
| * determine where to make the map go to. | |||
| * | |||
| * @param {string} [forcedVenue] - If set, this venue will be used instead of the current venue. | |||
There was a problem hiding this comment.
I assume this param should be removed?
…on a Location can have different casing that the Venue name (administrative ID).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
How