Fix issues with object importing and tolerate unpadded empty strings in encrypted documents #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Correctly copy references to the root object - Deal with deep object graphs in a more stack-safe manner (we now only recurse within top-level objects, those usually are not that deep) See #412
|
@redfast00, you might want to throw your files at this one. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #414 +/- ##
=======================================
Coverage 98.83% 98.83%
=======================================
Files 113 113
Lines 16265 16298 +33
=======================================
+ Hits 16075 16108 +33
Misses 190 190
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
Make object importer more resilient
recurse within top-level objects, those usually are not that deep)
When decrypting strings and streams using one of PDF's AES-CBC-based crypt filters, if the plaintext is empty after decryption, do not reject it for lack of padding.
See #412.
Checklist
Please go over this checklist to increase the chances of your PR being worked on in a timely manner. Deviations are allowed with proper justification (see previous section).
For bug fixes (delete if not applicable)