Cache GuiInset after the value has been set #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a test case. Did not work in the demo, so implemented GuiInset fix. Associated demo case now works.
… it causes an error. This should be a user decision (Main cases are Delete / Backspace / any of the F1-F12).
|
Thanks for addidng this. Just to check, there isn't going to be a possibility in the future where the GuiInset is 0, because otherwise it will call the set function every time you request the mouse location? |
SirMallard
reviewed
Jun 30, 2024
| end | ||
|
|
||
| function widgets.getGuiInset() | ||
| return widgets.GuiInset or widgets.setGuiInset() |
There was a problem hiding this comment.
if widgets.GuiInset is 0 then it will fetch the inset every time rather than caching it. Is it worth changing the check to be:
return widgets.GuiInset ~= nil and widgets.GuiInset or widgets.setGuiInset()Just in case future updates change this behaviour?
SirMallard
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #54
getMouseLocation should now always return the true location.