Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race condition loading/writing config file #94

Open
zamaudio opened this issue Aug 18, 2020 · 0 comments · May be fixed by #95
Open

Race condition loading/writing config file #94

zamaudio opened this issue Aug 18, 2020 · 0 comments · May be fixed by #95

Comments

@zamaudio
Copy link

When fyrd is used in a multithreaded way, I ran into a bug where configparser could not read the config due to a previous thread reading or writing the config file at the same time.

I traced it back to a particular config key res_time being loaded every wait loop. It probably should be read outside of the loop, or even in the constructor.

Will be submitting a pull request with a fix.

@zamaudio zamaudio linked a pull request Aug 18, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant